Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use max base fee in builder #1764

Merged
merged 1 commit into from
Jul 23, 2024
Merged

use max base fee in builder #1764

merged 1 commit into from
Jul 23, 2024

Conversation

imabdulbasit
Copy link
Contributor

@imabdulbasit imabdulbasit commented Jul 22, 2024

The builder does not have know about upgrades and uses the base fee from the default chain in the Genesis file. To support chain config upgrades, the builder should use the highest base fees from the list of chain config upgrades and the default chain config.

@imabdulbasit imabdulbasit requested a review from QuentinI July 22, 2024 18:04
@imabdulbasit imabdulbasit marked this pull request as ready for review July 22, 2024 18:04
Copy link
Contributor

@QuentinI QuentinI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imabdulbasit imabdulbasit merged commit 1d6f7d3 into main Jul 23, 2024
14 checks passed
@imabdulbasit imabdulbasit deleted the ab/max-base-fee branch July 23, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants