RollCall changes
#1762
Closed
RollCall changes
#1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-maron
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
tbro
as code owners
Merged
imabdulbasit
approved these changes
Jul 26, 2024
| } | ||
|
|
||
| _ => { | ||
| return Err(anyhow::anyhow!("Unknown external message type")); |
There was a problem hiding this comment.
we can use bail!() here
| ) -> Result<Self> { | ||
| // Create the outbound message queue | ||
| let (outbound_message_sender, outbound_message_receiver) = | ||
| async_compatibility_layer::channel::bounded(10); |
There was a problem hiding this comment.
I think the event handling will be quick, but should the channel capacity be increased just to be on the safe side?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EspressoSystems/HotShot#3455
This PR:
Adds a message handling framework to handle
ExternalHotShot events. These are messages that are "external" to HotShot but that HotShot subscribers may want to about. It's like an out-of-band communication layer and prevents us from having to use a separate network to disseminate the information.Adds
RollCallfunctionality. The frontend will use this to aggregate node identities, starting with the public API URL. On startup a node'sRollCallInfowill be broadcast the network. Past that, we will have an external service occasionally sending these messages (e.g. when it restarts) and providing the data to the frontend.Adds a Public API URL as an optional argument. If not supplied, we will not send a
RollCallmessage.