Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update upgrades.md #1712

Merged
merged 4 commits into from
Jul 16, 2024
Merged

update upgrades.md #1712

merged 4 commits into from
Jul 16, 2024

Conversation

imabdulbasit
Copy link
Contributor

@imabdulbasit imabdulbasit commented Jul 15, 2024

  • This PR updates the doc/upgrades.md
  • clarifies the difference between migration and version bump
  • adds additional parameters for time-based upgrade

@imabdulbasit imabdulbasit linked an issue Jul 15, 2024 that may be closed by this pull request
@imabdulbasit imabdulbasit marked this pull request as ready for review July 15, 2024 16:57
I did some rewording. I hope it is clearer this way, but might be
worth getting a second opinion.
@tbro
Copy link
Contributor

tbro commented Jul 16, 2024

Just pushing a change seemed like the easiest way to incorporate my thoughts for improvements. Feel free to revert if you disagree.

@imabdulbasit
Copy link
Contributor Author

Just pushing a change seemed like the easiest way to incorporate my thoughts for improvements. Feel free to revert if you disagree.

Looks good, thanks!

doc/upgrades.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@sveitser sveitser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one question, not necessarily related to this PR.

doc/upgrades.md Outdated Show resolved Hide resolved
@imabdulbasit imabdulbasit merged commit 3116b56 into main Jul 16, 2024
14 checks passed
@imabdulbasit imabdulbasit deleted the abdul/update-upgrades branch July 16, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update docs/upgrades.md
3 participants