Allow nodes to fetch network config from peers #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbearer
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser and
tbro
as code owners
rob-maron
approved these changes
Jul 15, 2024
Comment on lines
+198
to
+199
| #[derivative(Debug(format_with = "fmt_opt_urls"))] | ||
| pub config_peers: Option<Vec<Url>>, |
There was a problem hiding this comment.
Is there any downside to changing this to Vec<Url> and then treating an empty vector as nothing? It may remove some complexity
There was a problem hiding this comment.
I personally prefer Option<Vec> when empty is qualitatively different from non-empty because the compiler forces you to handle the None case explicitly whenever you want to use the vector. Whereas with just Vec<Url>, it's pretty easy to forget to check is_empty which is bad when there's entirely separate logic you want to do in the empty case
rob-maron
added a commit
that referenced
this pull request
Jul 15, 2024
This allows nodes to fetch the network config from the `config` API of another node, instead of/in addition to local storage and the orchestrator. This could be useful when a node in an existing network is migrating to new storage, or when storage has been lost. In particular, Kudasai is currently not running their Cappuccino nodes because (for reasons still unknown) they lost their persisted network config, and now have no way of getting it back since the orchestrator is already shut down. * Adds a `PublicNetworkConfig` which wraps a `PublicHotShotConfig` * Has the `config/hotshot` endpoint return the network config instead of just the HotShot config, which is strictly more information * Adds functions to convert a `PublicNetworkConfig` to a proper `NetworkConfig` based on a given set of private keys * Adds configuration logic to fetch the network config from a peer on startup * Fix any issues with the network config being lost from persistent storage * New config serialization in `api/data_source.rs` * Configuration logic in `lib.rs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows nodes to fetch the network config from the
configAPI of another node, instead of/in addition to local storage and the orchestrator. This could be useful when a node in an existing network is migrating to new storage, or when storage has been lost. In particular, Kudasai is currently not running their Cappuccino nodes because (for reasons still unknown) they lost their persisted network config, and now have no way of getting it back since the orchestrator is already shut down.This PR:
PublicNetworkConfigwhich wraps aPublicHotShotConfigconfig/hotshotendpoint return the network config instead of just the HotShot config, which is strictly more informationPublicNetworkConfigto a properNetworkConfigbased on a given set of private keysThis PR does not:
Key places to review:
api/data_source.rslib.rs