Add anvil and postgres to dev-node image #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImJeremyHe
requested review from
nomaxg,
philippecamacho,
sveitser,
jbearer and
tbro
as code owners
|
@ImJeremyHe looks good to me. Have you tested the script to build the docker image locally? It would be useful to provide this information in the PR description, as the template suggests. |
sveitser
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1616
This PR:
espresso-dev-node.Dockerfile. It is more convenient based on that we hardly need a pinnedanvil.postgresbuild-docker-images-native.shHow to test this PR:
Run this command locally
And in this action https://github.com/EspressoSystems/espresso-sequencer/actions/runs/9935660410,
this docker image can be run without setting L1 url and postgres options