modify upgrade scripts for non-multisig, non-openzeppelin-defender deployments #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alysiahuggins
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
tbro
as code owners
alysiahuggins
requested review from
Ancient123
and removed request for
philippecamacho,
nomaxg,
ImJeremyHe and
tbro
zacshowa
approved these changes
Jul 23, 2024
| bool public permissionedProverEnabled; | ||
|
|
||
| /// @notice an array to store the L1 Block Heights where the finalizedState was updated | ||
| uint256[] public stateUpdateBlockNumbers; |
There was a problem hiding this comment.
Would it be better to have this as uint128[]? I'm not 100% sure how solidity lays out memory under the hood but we could potentially half the size of every element in this array if we are okay with the max value of an entry being (2^128) -1.
However, I also recognize this is a test file and gas costs might not be a factor here.
There was a problem hiding this comment.
yea it would be advantageous to allocate less bits to this! I'll change to uint64, thanks!
There was a problem hiding this comment.
actually looking at this again, since we're unsure about the future block sizes and this stores l1 blocks, sticking with uint256[] might be best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1704
This PR:
The existing script UpgradeLightClient.s.sol was created only for testing purposes for the demo LightClientV2. However, since the current LightClient contract has been deployed without OpenZeppelin Defender & without a multisig wallet, we need to maintain upgrade scripts for the current light client deployment.
Key places to review:
How to test this PR:
just sol-testTo run tests specific to upgrades run
forge test --match-contract LightClientUpgradeSameContractTest --ffi -vvvand
forge test --match-contract LightClientUpgradeToV2Test --ffi -vvvThings tested
DeployLightClient.s.solscriptUpgradeSameLightClient.s.solscript