test: arbitrary namespace payload bytes #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggutoski
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
tbro
as code owners
|
Would it be worth writing tests mixing abnormal payload size with negative length transactions? |
philippecamacho
approved these changes
Jul 8, 2024
Absolutely. This PR is just a stepping-stone. |
ggutoski
added a commit
that referenced
this pull request
Jul 11, 2024
ggutoski
added a commit
that referenced
this pull request
Jul 11, 2024
* stub for new tests ns_proof/tests.rs * ns_proof test: wrong inputs, refactor test * rename new file after rebase * add tests for hacked namespace proofs, tidy test * ns_payload test for negative len txs with abnormal payload byte len as per #1675 (comment) * add empty namespace, block to test as per #1691 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1538
This PR:
This PR does not:
Key places to review: