Make backtrace logging configurable: pretty-printed or logged #1674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to log panics via the tracing formatter, so they can be parsed and interpeted by Datadog. If
RUST_LOG_FORMAT=json
is not set, panics will be pretty-printed directly to standard out, as they have been until now.This PR:
RUST_LOG_FORMAT
Key places to review:
utils/src/logging.rs
has the logging setup code and config parameterscount-transactions
as the query service now has this functionalitylogging::Config::init
(for main binaries, to get the config from the command line) orsetup_test
Things tested
git grep setup_logging
andgit grep setup_backtrace
have no results outside the logging utils