Make Header.fee_info iterable
#1626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap `Vec<FeeInfo>` in a new type so we can implement things like `Committable` over it. Update code where possible to deal with the structure change. Further changes needed in hotshot (and builder?).
|
Superseded by #1659 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap
Vec<FeeInfo>in a new type so we can implement things likeCommittableover it. Update code where possible to deal with the structure change. Further changes needed in hotshot (and builder?).This PR:
Allows us to have multiple fees per block in order to implement Decaf version of Marketplace. It is an early stage to take comment on general direction.
This PR does not:
Currently compile. Some changes in the traits defined in HotShot will need to be updated before this can be shipped.
Key places to review:
FeeInfosis added tostate.rs, and most code updates occur there.FeeInfosinheaders.rs