Serialize L1 block numbers as hex strings #1534
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add newtype for L1 block number. - Implement serialization in backwards compatible manner. Although there is currently no test for this backwards compatibility. - Don't ignore "actual" files created from reference tests. - Remove "actual" files for successful tests, if they exist. After implementing this and looking at the JSON file I'm now of the opinion that we should throw the compatibility with L1 away. It looks rather messy and I don't see what we really gain from it. I now think we should just serialize everything in the way we think is best, most pretty or whatever. Close #1507
sveitser
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
jbearer and
tbro
as code owners
|
So what I'm saying is we should keep the new L1 block number type but actually serialize L1 block numbers as JSON number like our height, L1 timestamp like our timestamp. I think it's more important that our header serialization is internally consistent instead of L1 derived data being consistent with L1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After implementing this and looking at the JSON file I'm now of the opinion that we should throw the compatibility with L1 away. It looks rather messy and I don't see what we really gain from it. I now think we should just serialize everything in the way we think is best, most pretty or whatever.
Close #1507