Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo fixes #1456

Merged
merged 1 commit into from
May 14, 2024
Merged

Demo fixes #1456

merged 1 commit into from
May 14, 2024

Conversation

jbearer
Copy link
Member

@jbearer jbearer commented May 13, 2024

  • Avoid Linux local port range (>= 32768)
  • Some configuration fixes in the Docker demo

* Avoid Linux local port range (>= 32768)
* Some configuration fixes in the Docker demo
Copy link
Member

@ImJeremyHe ImJeremyHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am reading something about choosing port.
And I found this one:
https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml?search=30000

We should also avoid using 30000 according to this document.

@sveitser
Copy link
Collaborator

sveitser commented May 14, 2024

I think using a port that another software uses isn't such a big problem as long as we don't run that software. The problem is with dynamic ports because on each run there's a small probability that the port is used, which leads to non-determinism. If we would happen to choose a port that is always used by software running on the github runner it would fail every time and we would know.

@sveitser sveitser merged commit 684fb4b into main May 14, 2024
15 checks passed
@sveitser sveitser deleted the jb/ports branch May 14, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants