Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make L1 block number configurable at genesis #1441

Merged
merged 3 commits into from
May 9, 2024
Merged

Make L1 block number configurable at genesis #1441

merged 3 commits into from
May 9, 2024

Conversation

jbearer
Copy link
Member

@jbearer jbearer commented May 8, 2024

No description provided.

@jbearer jbearer enabled auto-merge May 9, 2024 15:43
tbro
tbro approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@tbro tbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only doubt is if there may be some danger in allocating a very large vector of chunks. But I don't currently have any good ideas of how to avoid it, and if it were a problem could be seen as a future optimization.

@jbearer jbearer merged commit 8f46048 into main May 9, 2024
14 of 15 checks passed
@jbearer jbearer deleted the jb/l1-genesis branch May 9, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbro tbro tbro approved these changes

@nomaxg nomaxg Awaiting requested review from nomaxg

@philippecamacho philippecamacho Awaiting requested review from philippecamacho philippecamacho is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe is a code owner

@sveitser sveitser Awaiting requested review from sveitser sveitser is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbearer @tbro