Use fee from builder #1361
Merged
Use fee from builder #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbearer
force-pushed
the
feat/builder-fee
branch
from
3175a3f to
1bb374f
Compare
jbearer
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser and
tbro
as code owners
jbearer
force-pushed
the
feat/builder-fee
branch
from
1bb374f to
ef5ef3c
Compare
tbro
requested changes
Apr 25, 2024
Since the builder fee is actually being charged now, instead of silently ignored, I had to update all the tests to prefund the builder account. I deleted `test_catchup` because it wasn't working nicely with prefunding the builder account with a forgotten state, but it wasn't testing anything that the newer `test_catchup_live` wasn't also testing in a better way.
jbearer
force-pushed
the
feat/builder-fee
branch
from
0c64fbf to
390db12
Compare
tbro
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.