chore: remove dev-deploy and refactor deploy.rs #1338

alxiong · 2024-04-18T05:30:08Z

Close #1177

Major changes include:

refactor bin/deploy.rs to separate out the reusable code to a utils/deployer.rs module
- meanwhile fix the different deployment logic for LightClientMock and LightClient as I reviewed in Add support for deploying a mock light client contract #1322
remove just dev-deploy command and replace deployment logic inside rust to directly use sequencer_utils::deployer's APIs.

…mock and non-mock

sveitser

LGTM, but let's wait for an ark-srs update that works with hotshot.

alxiong added 5 commits April 18, 2024 13:27

refactor sc deployer code for reuse, fix errs in logic for deploying …

944992b

…mock and non-mock

remove unnecessary generic type hint

b364129

move deployer.rs to utils/ to avoid circular dep

3782ac2

remove dev-deploy

378066a

Merge remote-tracking branch 'origin/main' into remove-dev-deploy

3e22872

alxiong marked this pull request as ready for review April 18, 2024 07:34

alxiong requested review from nomaxg, philippecamacho, ImJeremyHe, sveitser and jbearer as code owners April 18, 2024 07:34

alxiong added 3 commits April 18, 2024 20:26

try not to override since we use nix in ci

867241d

another attempt to pacify nix

8634206

use global env var for srs size in ci

92d7ba7

alxiong force-pushed the remove-dev-deploy branch from 17c9118 to 92d7ba7 Compare April 18, 2024 15:17

alxiong added 2 commits April 19, 2024 00:16

try expanding out

638decf

update ark-srs to 0.3.0

f06342d

sveitser approved these changes Apr 19, 2024

View reviewed changes

alxiong added 3 commits April 19, 2024 20:19

update ark-srs to 0.3.1

84eb16f

Merge remote-tracking branch 'origin/main' into remove-dev-deploy

f6a3502

update demo-native ci

a59c409

alxiong merged commit 935e80a into main Apr 19, 2024
15 checks passed

alxiong deleted the remove-dev-deploy branch April 19, 2024 13:35

Provide feedback