Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Push CDN] Dockerfiles - change ENTRYPOINT to CMD #1334

Merged
merged 2 commits into from
Apr 16, 2024
Merged

[Push CDN] Dockerfiles - change ENTRYPOINT to CMD #1334

merged 2 commits into from
Apr 16, 2024

Conversation

rob-maron
Copy link
Contributor

No description provided.

@rob-maron rob-maron requested a review from Ancient123 April 16, 2024 21:37
@Ancient123
Copy link
Member

This is going to break the docker compose file (and cloud deploy) unless we update the commands on those as well.

@rob-maron
Copy link
Contributor Author

This is going to break the docker compose file (and cloud deploy) unless we update the commands on those as well.

Good point, fixed

@Ancient123 Ancient123 merged commit 1555fb4 into main Apr 16, 2024
15 checks passed
@Ancient123 Ancient123 deleted the rm/update-dockers branch April 16, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ancient123 Ancient123 Ancient123 approved these changes

@nomaxg nomaxg Awaiting requested review from nomaxg

@philippecamacho philippecamacho Awaiting requested review from philippecamacho philippecamacho is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe is a code owner

@sveitser sveitser Awaiting requested review from sveitser sveitser is a code owner

@jbearer jbearer Awaiting requested review from jbearer jbearer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rob-maron @Ancient123