Configure permissionless builder in native and docker demo #1324
Conversation
sveitser
changed the title
sveitser
requested review from
nomaxg,
philippecamacho,
ImJeremyHe and
jbearer
as code owners
| long, | ||
| env = "ESPRESSO_SEQUENCER_DA_SERVER_URL", | ||
| env = "ESPRESSO_BUILDER_SEQUENCER_URL", |
There was a problem hiding this comment.
I find this name a bit confusing. Is this the URL of an espresso sequencer node that is a DA committee member and provides the hotshot_event_service? If so, I'd suggest something like ESPRESSO_HS_EVENTS_SEQUENCER_URL, or even (referencing the naming used for the port, ESPRESSO_SEQUENCER_HOTSHOT_EVENT_STREAMING_API_URL, since this URL will be specific to that API, rather than the general URL of the node.
There was a problem hiding this comment.
Is this the URL of an espresso sequencer node that is a DA committee member and provides the hotshot_event_service?
Yes, think so.
There was a problem hiding this comment.
The explicit ESPRESSO_SEQUENCER_HOTSHOT_EVENT_STREAMING_API_URL is probably best.
| @@ -25,12 +24,11 @@ pub struct NonPermissionedBuilderOptions { | |||
| /// URL of the HotShot DA web server. | |||
There was a problem hiding this comment.
This comment should also be updated. @move47
A bunch of fixes to make the builder work.