merklized state catchup #1316
Merged
merklized state catchup #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbearer
reviewed
Apr 10, 2024
jbearer
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Have some more comments on the storage update and apply_header. Also, once we're happy with apply_header, let's not forget to update validate_and_apply_header to just call apply_header and do whatever extra validation is needed, rather than having the apply logic duplicated and spread out over many different functions
jbearer
reviewed
Apr 11, 2024
jbearer
reviewed
Apr 11, 2024
jbearer
reviewed
Apr 12, 2024
imabdulbasit
force-pushed
the
abdul/update-deps
branch
from
6fd92ca to
7854deb
Compare
* Change names of APIs to avoid API names with multiple path segments -- this is not currently supported in tide-disco * Use same data source for leaf subscription in `update_state_storage_loop` that we populate in the normal update loop * Make sure we don't hold a lock on the data source when we potentially block waiting for new objects to be populated * Populate genesis state in database * Handle empty state better * Populate fee state with builder accounts in test * Add test for fee API
jbearer
approved these changes
Apr 16, 2024
imabdulbasit
requested review from
nomaxg,
philippecamacho,
ImJeremyHe and
sveitser
as code owners
imabdulbasit
force-pushed
the
abdul/update-deps
branch
from
948b839 to
438c13a
Compare
imabdulbasit
force-pushed
the
abdul/update-deps
branch
from
438c13a to
16f0e4b
Compare
* [DRAFT] Builder ECDSA signatures Right now just to discuss if this goes in the right direction * Fix builder crate * WIP: verify builder commitment in block header * Update hotshot-builder-core * Compiles * Some cleanup * Update dependencies * Patch for patch for branch... * Update builder tests * Remove commented code * Another problem spot, as noted by @move47 * Make signature in Header::new match the new format expected in fee validation * Separate fee commitment from builder commitment * Ignore tide vulnerabilities * Fix merlized state updates * This won't pass. * Update hotshot, builder * Fix demo smoketest * So, this isn't ideal, but... using the same commitment, reencoded * Some kind of merge error? Duplicate block... * Replace magic numbers with constants * Start builder before sequencers * wait for ready * wait without libp2p * add logging statements * Remove explicit k256 dependency We don't need the `serde` feature of `k256` anymore because we don't use serde on VerifyingKey anymore so we can use re-exported ethers k256 instead. Rename EthSigningKey to EthKeyPair in Display. * smoke-test: increase blocks and txns timeout Currently block and transaction production can be irregular. Increase the timeout while we are working on fixing it to make the CI less flaky. * Log what information is fetched from peers * Prefund all sequencer accounts At the moment the sequencers still build blocks themselves, prefunding their accounts prevents validation errors if blocks are not built by the permissionless builder. * Periodically log successfully applied header This makes it easier to tell that a node is making progress by looking at the logs. --------- Co-authored-by: Jeb Bearer <[email protected]> Co-authored-by: Nathan F Yospe <[email protected]> Co-authored-by: Jeb Bearer <[email protected]> Co-authored-by: Nathan F Yospe <[email protected]> Co-authored-by: Rob <[email protected]> Co-authored-by: rob-maron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: