Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow that fails if process compose is edited but docker compose isn't #1284

Merged
merged 7 commits into from
Mar 27, 2024
Merged

Workflow that fails if process compose is edited but docker compose isn't #1284

merged 7 commits into from
Mar 27, 2024

Conversation

nomaxg
Copy link
Contributor

@nomaxg nomaxg commented Mar 27, 2024

No description provided.

jbearer
jbearer approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@jbearer jbearer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe have it print something like "If this was intentional, you may ignore this failure". Since in some cases you might change something in the native demo that doesn't affect the docker demo

@nomaxg nomaxg merged commit d0ccb9e into main Mar 27, 2024
14 of 15 checks passed
@nomaxg nomaxg deleted the process-workflow branch March 27, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbearer jbearer jbearer approved these changes

@philippecamacho philippecamacho Awaiting requested review from philippecamacho philippecamacho is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe is a code owner

@sveitser sveitser Awaiting requested review from sveitser sveitser is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nomaxg @jbearer