Skip to content

Commit

Permalink
Remvove extraneous public_key field from BidTx
Browse files Browse the repository at this point in the history
Also some obsolete TODOs
  • Loading branch information
tbro committed Jul 18, 2024
1 parent 3cd6e24 commit 0c32bb4
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
3 changes: 0 additions & 3 deletions types/src/v0/impls/auction.rs
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ impl Default for BidTxBody {
Self {
url: Url::from_str("https://sequencer:3939").unwrap(),
account: key.fee_account(),
public_key: FeeAccount::default(),
gas_price: FeeAmount::default(),
bid_amount: FeeAmount::default(),
view: ViewNumber::genesis(),
Expand Down Expand Up @@ -143,7 +142,6 @@ impl From<FeeError> for ExecutionError {
}
}

// TODO consider moving common functionality to trait.
impl BidTx {
/// Execute `BidTx`.
/// * verify signature
Expand All @@ -161,7 +159,6 @@ impl BidTx {
// any case we can charge the bids and gas during execution.
self.charge(state)?;

// TODO what do we return in good result?
Ok(())
}
/// Charge Bid. Only winning bids are charged in JIT.
Expand Down
3 changes: 0 additions & 3 deletions types/src/v0/v0_3/auction.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ pub struct BidTxBody {
/// The bid amount designated in Wei. This is different than
/// the sequencing fee (gas price) for this transaction
pub(crate) bid_amount: FeeAmount,
// TODO I think this will end up being a `FeeAccount`
/// The public key of this sequencer
pub(crate) public_key: FeeAccount,
/// The URL the HotShot leader will use to request a bundle
/// from this sequencer if they win the auction
pub(crate) url: Url,
Expand Down

0 comments on commit 0c32bb4

Please sign in to comment.