Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize tests and add epoch upgrade test #4012

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Conversation

ss-es
Copy link
Contributor

@ss-es ss-es commented Jan 8, 2025

This PR:

  • Reorganizes tests, creating a new CI test group for epoch tests (tests_6)
  • Cleans up some justfile commands, removing a bunch that were too specific. Local testing can now be done with just test <testname> (optionally --nocapture).
  • Adds a test for an upgrade to a version enabling epochs, but the test is currently disabled because it fails
  • Adjusts the marketplace version in EpochsTestVersions, since we expect to deploy epochs well before the marketplace.

This PR does not:

Key places to review:

@ss-es ss-es marked this pull request as ready for review January 8, 2025 18:50
@ss-es ss-es requested a review from bfish713 as a code owner January 8, 2025 18:50
@lukaszrzasik
Copy link
Contributor

I think something has changed how tests are run locally. I used to run tests locally like this but now I'm getting an error:

$ just test test_success_with_epochs
echo Running test test_success_with_epochs
Running test test_success_with_epochs
RUST_LOG=warn,hotshot_task_impls=debug cargo nextest run --profile local test_success_with_epochs --lib --bins --tests --benches --workspace
error: no such command: `nextest`

	Did you mean `test`?

	View all installed commands with `cargo --list`
	Find a package to install `nextest` with `cargo search cargo-nextest`
error: Recipe `test` failed on line 59 with exit code 101

@lukaszrzasik
Copy link
Contributor

lukaszrzasik commented Jan 9, 2025

I've been analysing the reason for the test failures. I think I know why but need to confirm it.

@ss-es ss-es merged commit 5034a64 into main Jan 10, 2025
18 checks passed
@ss-es ss-es deleted the ss/test-epoch-upgrade branch January 10, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants