Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EPOCH_HEIGHT as an associated constant in NodeType #3997

Merged
merged 8 commits into from
Jan 6, 2025
Merged

Remove EPOCH_HEIGHT as an associated constant in NodeType #3997

merged 8 commits into from
Jan 6, 2025

Conversation

ss-es
Copy link
Contributor

@ss-es ss-es commented Jan 2, 2025 •
edited
Loading

This PR:

  • Removes EPOCH_HEIGHT as an associated constant in NodeType (this was easier than remove epoch_height from HotShotConfig)
  • Cleans up some integration test code. epoch_height must now be set explicitly via TestDescription

This PR does not:

Key places to review:

@ss-es ss-es requested a review from bfish713 as a code owner January 2, 2025 17:19
@ss-es ss-es merged commit b8da9b4 into main Jan 6, 2025
17 checks passed
@ss-es ss-es deleted the ss/remove-epoch-associated-const branch January 6, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pls148 pls148 pls148 approved these changes

@bfish713 bfish713 Awaiting requested review from bfish713 bfish713 is a code owner

Assignees

@jparr721 jparr721

@rob-maron rob-maron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ss-es @pls148 @jparr721 @rob-maron