Handle HighQcSend #3919
Merged
Handle HighQcSend #3919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss-es
reviewed
Nov 25, 2024
crates/task-impls/src/network.rs
Outdated
| HotShotEvent::HighQcSend(quorum_cert, leader, sender) => Some(( | ||
| sender, | ||
| MessageKind::Consensus(SequencingMessage::General( | ||
| GeneralConsensusMessage::HighQc(quorum_cert.to_qc()), |
There was a problem hiding this comment.
can we change GeneralConsensusMessage::HighQc to a QuorumCertificate2?
it's not deployed so I think we can make the breaking change, and I think we would be gated on the same version (epochs)
There was a problem hiding this comment.
yeah, that's a good idea.
ss-es
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
This PR does not:
Key places to review: