fix orchestrator validator args #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#2168 changes this, but the examples aren't included in the basic lint/build anymore Having a problem with some of the examples (like all-webserver), will add to this PR |
sveitser
reviewed
Dec 8, 2023
sveitser
reviewed
Dec 8, 2023
| args.url, | ||
| args.port | ||
| ); | ||
| tracing::error!("connecting to orchestrator at {:?}:{:?}", args.url,); |
There was a problem hiding this comment.
Suggested change
| tracing::error!("connecting to orchestrator at {:?}:{:?}", args.url,); | |
| tracing::error!("connecting to orchestrator at {:?}", args.url); |
Co-authored-by: Mathis <[email protected]>
Ah yes, we also need to update those examples. |
rob-maron
approved these changes
Dec 8, 2023
jbearer
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
This PR does not:
Key places to review:
orchestrator/src/client.rs
How to test this PR:
Run
cargo run --example orchestrator-webserver --features="libp2p/rsa " -- http://localhost:5555 ./crates/orchestrator/run-config.tomlin one terminal andcargo run --example multi-validator-webserver --features="libp2p/rsa" -- 10 http://localhost:5555in another. It should correctly start consensus.