Fix potential buffer overflows

ErikMinekus · Jan 4, 2021 · 75c1c13 · 75c1c13
1 parent cec90d1
commit 75c1c13
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/addons/sourcemod/scripting/advertisements.sp b/addons/sourcemod/scripting/advertisements.sp
@@ -306,7 +306,7 @@ void ProcessVariables(const char[] message, char[] buffer, int maxlength)
     int buf_idx, i, name_len;
     ConVar hConVar;
 
-    while (message[i]) {
+    while (message[i] && buf_idx < maxlength - 1) {
         if (message[i] != '{' || (name_len = FindCharInString(message[i + 1], '}')) == -1) {
             buffer[buf_idx++] = message[i++];
             continue;

diff --git a/addons/sourcemod/scripting/advertisements/chatcolors.sp b/addons/sourcemod/scripting/advertisements/chatcolors.sp
@@ -252,7 +252,7 @@ void ProcessChatColors(const char[] message, char[] buffer, int maxlength)
     int buf_idx = PreFormat(buffer, maxlength);
     int i, name_len;
 
-    while (message[i]) {
+    while (message[i] && buf_idx < maxlength - 1) {
         if (message[i] != '{' || (name_len = FindCharInString(message[i + 1], '}')) == -1) {
             buffer[buf_idx++] = message[i++];
             continue;