Correcting issues in ered_client and ered_connection
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the batch size counter was not increased previously the batch size was always infinite. Signed-off-by: Björn Svensson <[email protected]>
The function in ered_client handling stray messages from a defunct client has a faulty signature which could result it a crash. Signed-off-by: Björn Svensson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following issues are corrected with this PR:
Correcting signature on function handling a
command_reply.The function in
ered_clienthandling stray messages from a defunct clienthas a faulty signature which could result it a crash.
Correcting
batch_sizebug in connection options.Since the batch size counter was not increased previously
the batch size was always infinite.