Fix :Customer ID being retained in customer_ID #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you create an invoice, and enter a customer name, the input fetches the customers in Database. Which is then using jquery put into a hidden field "Customer_ID" in invoice form. So in case user decides he wants to create a new customer from the form, he erases the selected customer name from customer field, but the customer_ID is retained in the hidden input field. This can be fixed by adding the following code in the invoice_form.tpl to remove the old fetched customer ID in the customer_id input field.
Since the model actually checks Email field when figuring out whether to add new customer or not, I have updated the code to remove the value from the email input field as well, otherwise there is no point in just removing the value from customer_id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you create an invoice, and enter a customer name, the input fetches the customers in Database.
Which is then using jquery put into a hidden field "Customer_ID" in invoice form.
So in case user decides he wants to create a new customer from the form, he erases the selected customer name from customer field, but the customer_ID is retained in the hidden input field.
This can be fixed by adding the following code in the invoice_form.tpl to remove the old fetched customer ID in the customer_id input field.