-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow https download and GITHUB_TOKEN in VEP Install #1805
Open
nakib103
wants to merge
8
commits into
Ensembl:postreleasefix/114
Choose a base branch
from
nakib103:install_https
base: postreleasefix/114
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olaaustine
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nakib103, just minor suggestions. Thank you!
Hi @olaaustine , thanks for the good suggestions, have updated them all. Also, updated the usage text in public plugins doc - https://github.com/Ensembl/public-plugins/pull/844/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENSVAR-6431
--USE_HTTPS_PROTO
which would allow using https protocol to download cache and FASTA file instead of FTP. Useful in network where FTP port is blocked.--GITHUBTOKEN
or--GITHUB_TOKEN
which would allow providing GITHUB token to query GitHub API using curl and allow increase in rate limit.Public doc update - Ensembl/public-plugins#844