Add a core status attribute #15
Conversation
|
@ethanaobrien: I've only set the ones I know to be |
|
Here are my thoughts real quick. I don't think cores should be added to the cores.json at all if they don't build - if that happens, there are always going to be people asking why it isn't building, and not even trying. I also kinda think that with how this project runs, that beta and experimental are both one core (like your changes to cores.json only used experimental, with none marked as beta) Let me know on your thoughts on these |
|
You're right of course that they wouldn't be in cores.json unless they had passed some basic build testing. But I wanted to be able to include sub-optimal cores in the script to allow for testing purposes. The ones I marked experimental is because they do build, but I still need to do some proper testing to ensure they work. They would move up to beta (though that could be relabled to "unstable" perhaps?) with more testing. I was thinking along the lines of cores like picodrive which we know is a bit dodgy, could have a label of beta because there were issues with running it, and giving it a label like that sets end user expectations. Having the value there also allows us to filter work in progress or known-faulty cores from release builds, but leave them in nightlies for testing purposes. This PR is very much in the area of a proposal/suggestion :) |
| argumentstring="$argumentstring `echo $rowarg | base64 --decode`" | ||
| done | ||
| # only compile if the status attribute is not 3 | ||
| if [ -a "$status" != 3 ]; then |
There was a problem hiding this comment.
Could we "if status == 3 then continue"? or is that not available in bash?
Adds an attribute called "status". The intention is to allow EJS to display the state of the build to manage user expectations if a core is still in test or not completely functional.
Status can have one of the following values:
0or not set =stable1=beta2=experimental3=don't build- the build script will skip building the core