Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to update the polyfill of the geometries to hexagons using the latest H3 library.
I tested the example in the README.md and the behavior is still the expected.
A few minor changes:
I updated the
requirements.txt
so it now installs versionh3==4.1.2
.Some scripts (
urbanpy/geom/geom.py
andurbanpy/utils/utils.py
) were using oldh3
imports:from h3 import h3
.import h3
.The example in the README.md was wrong:
up.geom.gen_hexagons(res, city)
is supposed to return ageopandas.GeoDataFrame
with the hexagons and the geometries. The example was doing something likehexs, hex_centroids = up.geom.gen_hexagons(res, city)
, which is not how the function is used.