Tests for warnings in the body section #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmmut
requested changes
Mar 13, 2018
test/vcf/optional_policy_test.cpp
Outdated
|
|
||
| SECTION("Reference and alternate alleles share first nucleotide") | ||
| { | ||
| vcf::Record record1( |
There was a problem hiding this comment.
use { } for constructors. using ( ) is somewhat deprecated unless necessary.
test/vcf/optional_policy_test.cpp
Outdated
| { }, | ||
| { }, | ||
| source); | ||
| record1.types = { vcf::RecordType::INDEL }; |
There was a problem hiding this comment.
this line is not necessary, the constructor takes care
test/vcf/optional_policy_test.cpp
Outdated
| { }, | ||
| { }, | ||
| source); | ||
| record2.types = { vcf::RecordType::MNV }; |
There was a problem hiding this comment.
if you want it to be a MNV, remove this line and change the ref and alt alleles to GT and AC respectively, look at Record::set_types
test/vcf/optional_policy_test.cpp
Outdated
| { }, | ||
| { }, | ||
| source); | ||
| record3.types = { vcf::RecordType::INDEL }; |
|
Thank you for suggesting the changes. I have added them in next commit. Can you please take a look? |
jmmut
requested changes
Mar 15, 2018
test/vcf/optional_policy_test.cpp
Outdated
| } | ||
| } | ||
|
|
||
| TEST_CASE("Record Reference Alternate matching warnings", "[body reference alternate matching warnings]") |
There was a problem hiding this comment.
tags are a way to group tests, so it's not really useful to have so many specific tags.
https://github.com/catchorg/Catch2/blob/master/docs/test-cases-and-sections.md#tags
I would keep just [warnings] for these tests
srbcheema1
force-pushed
the
body_warnings
branch
2 times, most recently
from
4a4d6d9 to
cdcf5df
Compare
srbcheema1
force-pushed
the
body_warnings
branch
from
cdcf5df to
f106dab
Compare
srbcheema1
force-pushed
the
body_warnings
branch
from
f106dab to
ce18628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve issue #92 partially.
Added tests for position, id, reference alternate matching and info imprecise.