EVA-3445 Added test for accession-commons recover method #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcezard
approved these changes
Nov 16, 2023
| private static final String TEST_DB = "test-db"; | ||
|
|
||
| @Autowired | ||
| private SubmittedVariantAccessioningRepository repository; |
There was a problem hiding this comment.
Suggested change
| private SubmittedVariantAccessioningRepository repository; | |
| private SubmittedVariantAccessioningRepository mongoRepository; |
| } | ||
|
|
||
| private void verifyInitialDBState() { | ||
| assertEquals(30, repository.count()); |
There was a problem hiding this comment.
Suggested change
| assertEquals(30, repository.count()); | |
| // Initial state is 2 blocks are "reserved" but not "committed" in postgresql | |
| // 30 accessions have been used in mongoDB but are not reflected in the block allocation table | |
| assertEquals(30, repository.count()); |
| assertEquals(5000000059l, block2.getLastValue()); | ||
| } | ||
|
|
||
| private void runJob() throws Exception { |
There was a problem hiding this comment.
Suggested change
| private void runJob() throws Exception { | |
| private void runAccessioningJob() throws Exception { |
| repository.deleteAll(); | ||
|
|
||
| List<SubmittedVariantEntity> submittedVariantEntityList = new ArrayList<>(); | ||
| for(long i=5000000000l;i<5000000030l;i++){ |
There was a problem hiding this comment.
Can you change the range slightly so that one block get committed partially ?
I would suggest adding a 3rd block 60->90 in the block allocation table and 1 or 2 submitted variant accession in this range.
I'd be curious to see how the recover state deal with this situation.
apriltuesday
approved these changes
Nov 20, 2023
tcezard
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.