fix: Bitv and large_enough #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`is_subset` was used to check if two sets intersect. After correcting `is_subset` this broke the iteration on the Hullot tree. The other change are more esthetical: - rename `is_singleton` to `is_singleton_or_empty` to reflexed what the implementation is doing - implement `mem`directly using primitive fonction instead of `is_subset`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_subsetwas used to check if two sets intersect. After correctingis_subsetthis broke the iteration on the Hullot tree.The other change are more esthetical:
is_singletontois_singleton_or_emptyto reflexed what the implementation is doingmemdirectly using primitive fonction instead ofis_subset