Use VUE3-extension #126
Merged
Use VUE3-extension #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"*://*.primevideo.com/*", "*://*.amazon.com/*", "*://*.amazon.co.jp/*", "*://*.amazon.de/*", "*://*.amazon.co.uk/*", ]
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| headers: { | ||
| accept: "application/json", | ||
| Authorization: | ||
| "Bearer eyJhbGciOiJIUzI1NiJ9.eyJhdWQiOiI5OWQyMWUxMmYzNjU1MjM4NzdhNTAwODVhMmVjYThiZiIsInN1YiI6IjY1M2E3Mjg3MjgxMWExMDBlYTA4NjI5OCIsInNjb3BlcyI6WyJhcGlfcmVhZCJdLCJ2ZXJzaW9uIjoxfQ.x_EaVXQkg1_plk0NVSBnoNUl4QlGytdeO613nXIsP3w", |
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical
| } | ||
| // to parse html umlaut symbols like ä to ä | ||
| function decodeHtmlEntities(str: string) { | ||
| return new DOMParser().parseFromString("<!doctype html><body>" + str, "text/html").body.textContent |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 2 days ago
To fix the problem, we need to ensure that the input to decodeHtmlEntities is properly sanitized before being parsed as HTML. This can be achieved by using a library that safely decodes HTML entities without interpreting the input as HTML. One such library is he, which provides robust HTML entity encoding and decoding.
- Install the
helibrary. - Replace the
decodeHtmlEntitiesfunction with a function that uses thehelibrary to decode HTML entities safely.
Suggested changeset
2
src/content-script/netflix.ts
| @@ -97,4 +97,5 @@ | ||
| // to parse html umlaut symbols like ä to ä | ||
| import he from 'he'; | ||
| function decodeHtmlEntities(str: string) { | ||
| return new DOMParser().parseFromString("<!doctype html><body>" + str, "text/html").body.textContent | ||
| return he.decode(str); | ||
| } |
package.json
Outside changed files
| @@ -36,3 +36,4 @@ | ||
| "vue-router": "^4.5.0", | ||
| "webextension-polyfill": "^0.12.0" | ||
| "webextension-polyfill": "^0.12.0", | ||
| "he": "^1.2.0" | ||
| }, |
This fix introduces these dependencies
| Package | Version | Security advisories |
| he (npm) | 1.2.0 | None |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.