Load HTML5 splashscreen dynamically from HTML file in metadata #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfischer-okarin
commented
Dec 12, 2024
Comment on lines
-559
to
-572
| img.onload = function() { // once we know its size, scale it, keeping aspect ratio. | ||
| var pct = 30; | ||
| var w = img.naturalWidth; | ||
| var h = img.naturalHeight; | ||
| if (!w || !h || (w == h)) { | ||
| img.style.width = '' + pct + '%'; | ||
| img.style.height = '' + pct + '%'; | ||
| } else if (w > h) { | ||
| img.style.width = '' + pct + '%'; | ||
| } else { | ||
| img.style.height = '' + pct + '%'; | ||
| } | ||
| img.style.display = 'block'; | ||
| } |
There was a problem hiding this comment.
I could not sanely reproduce this Javascript that dynamically sets the icon CSS depending on its actual width/height.
But I replaced it with static styles (fixed max-height max-height of 30%) that should hopefully have the same effects.....
I can try and take some comparison screenshots later with some extremely proportioned icons
kfischer-okarin
changed the title
kfischer-okarin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a little experiment - specifying your HTML 5 splash screen via a little HTML file you put at
metadata/html5-splashscreen.html