Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag support to doppler_secrets_sync_aws_secrets_manager #70

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

watsonian
Copy link
Contributor

@watsonian watsonian commented Jan 8, 2024

This plumbs through tag support to doppler_secrets_sync_aws_secrets_manager.

Closes ENG-7065.

@watsonian watsonian requested a review from nmanoogian January 8, 2024 20:28
@watsonian watsonian force-pushed the watsonian/asm-tag-support branch from b847413 to d8be4fa Compare January 8, 2024 20:49
@ViacheslavKudinov
Copy link
Contributor

Addresses #69

Copy link
Member

@nmanoogian nmanoogian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! I did some light testing locally and this behaves as I'd expect

@watsonian watsonian merged commit 7dd1266 into master Jan 24, 2024
4 checks passed
@watsonian watsonian deleted the watsonian/asm-tag-support branch January 24, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants