fix: add entity in where for fetch when fetch by ref #32652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
requested changes
Jan 14, 2025
eldy
added
the
PR to fix - See feedback in comments
rycks
approved these changes
Jan 16, 2025
lvessiller-opendsi
approved these changes
Jan 16, 2025
FHenry
deleted the
18_fix_fetch_expensereport_wihtout_entity_check_by_ref
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With multicompany, when try to diplay PDF of exepnese report
document.php=>dol_check_secure_access_document=>$tmpexpensereport->fetch('', $refname);
if there is other exepnese report with the same ref in other entity the test done is not correct (bad fk_user_create)