Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUAL upgrade jQuery Jeditable to 2.0.21 #32629

Closed
wants to merge 6 commits into from

Conversation

hregis
Copy link
Contributor

@hregis hregis commented Jan 11, 2025

No description provided.

@hregis
Copy link
Contributor Author

hregis commented Jan 11, 2025

@eldy @mdeweerd
i don't understand this error :

Short PHP opening tag used with echo; expected "<?php echo DOL_URL_ROOT ..." but found "<?= DOL_URL_ROOT

https://www.php.net/manual/en/language.basic-syntax.phptags.php

@hregis
Copy link
Contributor Author

hregis commented Jan 11, 2025

short echo tag "<?=" is not a short open tag "<?"

@hregis
Copy link
Contributor Author

hregis commented Jan 11, 2025

@eldy @mdeweerd the new codesniffer rule found short open tag "<?" and exclude short echo tag "<?="

In php to allow <?= It seems it is the same option than to allow short tag <?
And php recommand to didable <? So mechanically we must avoid <?=
You can replace with <?php echo

@hregis hregis changed the title QUAL upgrade jQuery Jeditable to 2.0.19 QUAL upgrade jQuery Jeditable to 2.0.21 Jan 11, 2025
@mdeweerd
Copy link
Contributor

As you indicated this is probably configurable as a PHP Codesniffer option.

However the question is what the rule is for Dolibarr. There was a document explaining that PSR-2 or PSR-12 or so was applicable with a list of the exceptions (not the phpcs configuration itself).
So it depends on the policy for Dolibarr.

@hregis
Copy link
Contributor Author

hregis commented Jan 11, 2025

jQuery Jeditable n'est plus maintenu et va être remplacé par Malle qui ne dépendra plus de jQuery

@hregis hregis closed this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants