fix join societe_commerciaux in societe list #32557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
that is a bug in 18.0 but in 20.0 the solution was different with an EXIST and a subselect request because we don't use data from the join ... |
rycks
approved these changes
Jan 9, 2025
lvessiller-opendsi
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In societe/list.php, when we filter the list of tiers with the sale representatives and when the hook printFieldListFrom is used, we get "no such field xxx in on clause" error.
This is the same problem as here: #23941
To fix it i used INNER JOIN instead of comma join.