Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for incorrect total time calculation in project overview tab #32205

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

atm-quentin
Copy link
Contributor

Fix for incorrect total time calculation in project overview tab

Hello everyone,

I have created a pull request to fix an issue in the project overview tab related to the calculation of total_time.

Previously, the total_time variable was declared inside a for loop, causing it to be reset to 0 at each iteration rather than accumulating the total across all rows. In my fix, I moved the declaration and initialization of total_time outside the loop to ensure the sum is correctly calculated for all lines.

This adjustment resolves the incorrect total displayed in the overview.

Feel free to review and provide feedback on the pull request. Looking forward to your input!

Best regards,

@rycks
Copy link
Contributor

rycks commented Dec 5, 2024

Waw here is the bug : (screenshot)

image

Copy link
Contributor

@rycks rycks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@eldy eldy merged commit 6944966 into Dolibarr:18.0 Dec 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants