Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected removal of UMLS refs #1344

Open
dylan-barfield opened this issue Jun 10, 2024 · 2 comments
Open

Unexpected removal of UMLS refs #1344

dylan-barfield opened this issue Jun 10, 2024 · 2 comments
Assignees

Comments

@dylan-barfield
Copy link

Is your request related to a specific disease? Please describe.

We analyzed differences in the disease ontology version we had in our database for the last couple of years and the latest and found some unexpected removals of UMLS refs.

For example, Lynch syndrome (https://uts.nlm.nih.gov/uts/umls/concept/C4552100) was removed from Lynch syndrome (DOID:3883).

umls-ref-removal.txt

Describe the proposed change(s)
Please review the attached spreadsheet and add the UMLS refs back as appropriate.

References
NA

@csbjohnson
Copy link
Collaborator

csbjohnson commented Jun 10, 2024

Hi Dylan, @drobbarfield, thank you for your request on updating UMLS refs. We will review it and get back to you soon.

Best,
Claudia Marie Sánchez-Beato Johnson

@allenbaron allenbaron self-assigned this Jun 10, 2024
@allenbaron
Copy link
Collaborator

Thanks @drobbarfield for sharing these with us. DO's mappings to UMLS are primarily automated based on mappings from other vocabularies, such as MeSH and NCI. These don't always agree with one another. As I review various mappings, I'm going to add supporting notes for future reference.

The Lynch syndrome example probably lost the UMLS xref to Lynch syndrome because of complex and confusing mappings of UMLS to MeSH, NCI, and Orphanet... and lack of mappings to OMIM phenotypic series (or the DO). NCI and Orphanet have two distinct terms with a parent-child relationship that are using disease names which, in clinical practice, have mostly become synonymous (Lynch syndrome and HNPCC), while the MeSH term correctly has both names, but is linked to 4 separate UMLS entities. I'm adding back the lost UMLS mapping you shared and updating the current UMLS mappings to indicate they are actually broad matches and should not be included as xrefs.

allenbaron added a commit that referenced this issue Jun 21, 2024
allenbaron added a commit that referenced this issue Jun 25, 2024
allenbaron added a commit that referenced this issue Jun 27, 2024
allenbaron added a commit that referenced this issue Jun 28, 2024
allenbaron added a commit that referenced this issue Jun 28, 2024
Also contacted UMLS to fix incorrect conflation of these terms
in UMLS and MeSH.

Prompted by #1344
@allenbaron allenbaron added this to the November 2024 release milestone Nov 1, 2024
@allenbaron allenbaron removed this from the December 2024 release milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants