Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests that use flux and gaps #752

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Conversation

shihab-dls
Copy link
Collaborator

A dodal PR that I opened was found to have broken mx-bluesky CI.
These are the changes to address the dodal changes.

@rtuck99
Copy link
Contributor

rtuck99 commented Jan 16, 2025

Need to fix ispyb_dev_connection, test_load_centre_collect_full_plan system tests.

@rtuck99
Copy link
Contributor

rtuck99 commented Jan 16, 2025

Also should fix test_plan_system - type-checking is complaining about it

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (eac39cb) to head (f656778).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #752   +/-   ##
=======================================
  Coverage   86.97%   86.97%           
=======================================
  Files         101      101           
  Lines        6933     6933           
=======================================
  Hits         6030     6030           
  Misses        903      903           
Components Coverage Δ
i24 SSX 72.69% <ø> (ø)
hyperion 96.53% <ø> (ø)
other 96.58% <ø> (ø)

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (eac39cb) to head (ffb7999).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #752   +/-   ##
=======================================
  Coverage   86.97%   86.97%           
=======================================
  Files         101      101           
  Lines        6933     6933           
=======================================
  Hits         6030     6030           
  Misses        903      903           
Components Coverage Δ
i24 SSX 72.69% <ø> (ø)
hyperion 96.53% <ø> (ø)
other 96.58% <ø> (ø)

@shihab-dls
Copy link
Collaborator Author

Looks like CI is failing due to changes in dodal 981 now

Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shihab-dls shihab-dls merged commit b4f7195 into main Jan 17, 2025
22 checks passed
@shihab-dls shihab-dls deleted the remove_ophyd_references_fix branch January 17, 2025 11:27
@DominicOram
Copy link
Contributor

For posterity, this actually was caused by DiamondLightSource/dodal#985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants