-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests that use flux and gaps #752
Conversation
Need to fix |
Also should fix |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
=======================================
Coverage 86.97% 86.97%
=======================================
Files 101 101
Lines 6933 6933
=======================================
Hits 6030 6030
Misses 903 903
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
=======================================
Coverage 86.97% 86.97%
=======================================
Files 101 101
Lines 6933 6933
=======================================
Hits 6030 6030
Misses 903 903
|
Looks like CI is failing due to changes in dodal 981 now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
For posterity, this actually was caused by DiamondLightSource/dodal#985 |
A dodal PR that I opened was found to have broken mx-bluesky CI.
These are the changes to address the dodal changes.