Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to new attributes API and use pyright #51

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Update to new attributes API and use pyright #51

merged 1 commit into from
Dec 13, 2024

Conversation

jsouter
Copy link
Contributor

@jsouter jsouter commented Dec 3, 2024 •
edited
Loading

Closes #40

Uses FastCS from github main currently until a release is made for the new API.

@jsouter jsouter changed the title Use pyright instead of mypy Update to new attriubutes API and use pyright Dec 6, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.61%. Comparing base (833015c) to head (2aee79a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/fastcs_odin/__main__.py 28.57% 5 Missing ⚠️
src/fastcs_odin/odin_data.py 75.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   85.64%   85.61%   -0.04%     
==========================================
  Files          11       11              
  Lines         425      424       -1     
==========================================
- Hits          364      363       -1     
  Misses         61       61

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

GDYendell
GDYendell reviewed Dec 6, 2024
View reviewed changes
src/fastcs_odin/__main__.py Outdated Show resolved Hide resolved
src/fastcs_odin/odin_data.py Outdated Show resolved Hide resolved
src/fastcs_odin/odin_adapter_controller.py Outdated Show resolved Hide resolved
evalott100
evalott100 reviewed Dec 9, 2024
View reviewed changes
src/fastcs_odin/odin_adapter_controller.py Outdated Show resolved Hide resolved
src/fastcs_odin/odin_adapter_controller.py Outdated Show resolved Hide resolved
src/fastcs_odin/odin_adapter_controller.py Outdated Show resolved Hide resolved
tests/test_controllers.py Show resolved Hide resolved
@evalott100
Copy link

Github glitched out my comments so they weren't applied to the threads on Gary's review 🙃

@jsouter jsouter marked this pull request as draft December 9, 2024 09:33
@jsouter
Update for new FastCS attributes API
2aee79a 
Use pyright instead of mypy
@jsouter jsouter marked this pull request as ready for review December 9, 2024 11:09
@GDYendell GDYendell changed the title Update to new attriubutes API and use pyright Update to new attributes API and use pyright Dec 10, 2024
@jsouter jsouter merged commit 7530b8d into main Dec 13, 2024
26 of 28 checks passed
@jsouter jsouter deleted the pyright branch December 13, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evalott100 evalott100 evalott100 left review comments

@GDYendell GDYendell GDYendell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to use pyright
3 participants
@jsouter @evalott100 @GDYendell