-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make attenuator with enum filter values #969
Conversation
48fea8e
to
ac38ea6
Compare
I02_1FilterOneSelections, | ||
I02_1FilterTwoSelections, | ||
I02_1FilterThreeSelections, | ||
I02_1FilterFourSelections, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugly, but maybe it has to be. Open to suggestions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
==========================================
+ Coverage 95.88% 97.47% +1.58%
==========================================
Files 145 147 +2
Lines 6240 6208 -32
==========================================
+ Hits 5983 6051 +68
+ Misses 257 157 -100 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, I have opinionated change requests.
Co-authored-by: Joseph Ware <[email protected]>
Co-authored-by: Joseph Ware <[email protected]>
Co-authored-by: Joseph Ware <[email protected]>
Co-authored-by: Joseph Ware <[email protected]>
Co-authored-by: Joseph Ware <[email protected]>
Co-authored-by: Joseph Ware <[email protected]>
Co-authored-by: Joseph Ware <[email protected]>
Fixes some of #927
This will require a change in
mx_bluesky
before mergingInstructions to reviewer on how to test:
dodal connect p99
should still work assuming devices are connecteddodal connect i02_1
passesChecks for reviewer
dodal connect ${BEAMLINE}