Add csv reader #13
Merged
Add csv reader #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 12, 2024 17:00
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 4 +1
Lines 25 62 +37
=========================================
+ Hits 25 62 +37 ☔ View full report in Codecov by Sentry. |
* initial changes to refactor to typer * fix cli test for typer * add mocking for calculate_optimal_voltages function * added unitest to pyproject.toml * added typer to pyproject.toml * remove pytest from pyproject.toml * add typer cli test * add mocking and fixtures to tests * add type ignore flag to pandas object * fix indentation * add stdout assertion to test_app * combine the two tests add assertion for passed arguments rename mock object * add assertion for increment arg * change entrypoint from main to app * add parametrize to test cli with and without output_path arg * remove print statement * fix bug, change underscore to hyphen * fix unbound error on runner result --------- Co-authored-by: Luke Fiddy <[email protected]> Co-authored-by: root <[email protected]>
dan-fernandes
requested changes
Jan 7, 2025
tests/read_file_test.py
Outdated
| with patch("bimorph_mirror_analysis.read_file.pd.read_csv") as mock_read_csv: | ||
| mock_read_csv.return_value = raw_data | ||
| pivoted, initial_voltages, increment = read_bluesky_plan_output("input_path") | ||
| # expected_output = pd.read_csv(output_path) # type: ignore |
There was a problem hiding this comment.
Could: Delete comment
dan-fernandes
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added script to read csv files
added tests for this script
also pulled together scripts in main to run the program.