Close #40 Add support for test-containers to be compliant with native engine statements #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… engine statements
nurkiewicz
approved these changes
Nov 25, 2020
jpa2ddl-core/src/main/java/com/devskiller/jpa2ddl/DatabaseSchemaProcessor.java
Outdated
Show resolved
Hide resolved
| @@ -5,7 +5,12 @@ | |||
| /** | |||
| * Generation based on setting up embedded database and dumping the schema | |||
| */ | |||
| DATABASE, | |||
| EMBEDDED_DATABASE, | |||
There was a problem hiding this comment.
Maybe an overkill, but this isn't backward compatible? This enum is used as part of configuration?
There was a problem hiding this comment.
It is, but as we're releasing the stable version I don't have problem with breaking it
| } | ||
|
|
||
| private void validateSettings(GeneratorSettings settings) { | ||
| if (settings.getAction() == Action.UPDATE) { | ||
| if (settings.getOutputPath().exists() && !settings.getOutputPath().isDirectory()) { | ||
| throw new IllegalArgumentException("For UPDATE action outputPath must be a directory"); | ||
| } | ||
| if (settings.getGenerationMode() != GenerationMode.DATABASE) { | ||
| if (settings.getGenerationMode() != GenerationMode.EMBEDDED_DATABASE && settings.getGenerationMode() != GenerationMode.CONTAINER_DATABASE) { |
There was a problem hiding this comment.
Maybe some flag on GenerationMode to avoid &&? Also, the error message below is incorrect
| @@ -79,7 +79,6 @@ | |||
| <groupId>junit</groupId> | |||
| <artifactId>junit</artifactId> | |||
| <version>4.13.1</version> | |||
| <scope>test</scope> | |||
There was a problem hiding this comment.
For the reference, it's because of testcontainer's dependency on junit
…maProcessor.java Co-authored-by: Tomasz Nurkiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.