Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dgw): send close code 1005 when video streaming ends #1186

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

irvingoujAtDevolution
Copy link
Contributor

@irvingoujAtDevolution irvingoujAtDevolution commented Jan 11, 2025

Trying to make the websocket_compact function return a result with a new trait.
I tried to make a Generic type for the WithExplict but faild as the combination for With and Map trait generic and bounds is beyond my comprehension. I hope @CBenoit could make a better type than this...
feel free to edit it, and let me know your thoughts, thanks!

Copy link

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

@irvingoujAtDevolution
Copy link
Contributor Author

@CBenoit Thanks for much easier and cleaner advice!

@irvingoujAtDevolution irvingoujAtDevolution changed the title fix(dgw): Allow video-streamer to properly send code 1000 on stream finishes fix(dgw): Allow video-streamer to properly send code 1005 on stream finishes Jan 13, 2025
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I’ll leave you merge the PR! Don’t forget to update the description to include a changelog-friendly message, or to add Changelog: ignore if the change is for something that we didn’t release yet. (And I think that’s indeed the case!)

@CBenoit CBenoit changed the title fix(dgw): Allow video-streamer to properly send code 1005 on stream finishes fix(dgw): send close code 1005 when video streaming ends Jan 13, 2025
@irvingoujAtDevolution irvingoujAtDevolution merged commit 74625c4 into master Jan 14, 2025
36 checks passed
@irvingoujAtDevolution irvingoujAtDevolution deleted the make-stream-closable branch January 14, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants