-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dgw): remove notification from player #1182
base: master
Are you sure you want to change the base?
Conversation
Let maintainers know that an action is required on their side
|
shadowPlayer.onError((error) => { | ||
showNotification(`An error occurred: ${error}`, 'error'); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove this, how can we learn more about the error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can show an error icon or animation? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I think it’s best if we keep showing the error, even if it’s not localized 🤔
Let’s stick to removing only strings that are not critical, and hope that errors are not coming up too often.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok,I get your idea, I'll keep the notification
Changelog: ignore