Allow users to switch provider with GH Actions #214
Conversation
|
@lionello I just did this, but now I'm thinking it might be better as a variable for the action... let me know what you think. |
|
On the one hand we can make things a bit more explicit that way. On the other, if they're going to switch providers, then they'll have to use env vars/secrets for all the other provider related stuff anyway... |
| uses: DefangLabs/[email protected] |
| # Use GitHub Variables (https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables) | ||
| # to switch between providers. You'll need to make sure to also set the corresponding secrets for the provider you want to use. | ||
| DEFANG_PROVIDER: ${{ vars.DEFANG_PROVIDER || 'auto' }} |
There was a problem hiding this comment.
I think this is fine, but it's the first such variable that we use. Why wouldn't we add it as a param to the action? Seems more explicit that a hidden env var.
Not really. Depends on the provider. For AWS they'd likely use the credentials action. |
Samples Checklist
✅ All good!