-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added supported Compose spec properties #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress on this @commit111 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some links and tried to fill things out a bit further.
Co-authored-by: Jordan Stephens <[email protected]>
Co-authored-by: Jordan Stephens <[email protected]>
…/defang-docs into linda-compose-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor feedback
docs/concepts/compose.md
Outdated
``` | ||
|
||
:::info | ||
Read more about configuration in the [Configuration page](./configuration.md). | ||
After you set sensitive environment variables as blank or `null` values in the `compose.yaml` file, you can securely set their actual value in the Defang CLI. See our [Configuration page](/docs/concepts/configuration) for more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After you set sensitive environment variables as blank or `null` values in the `compose.yaml` file, you can securely set their actual value in the Defang CLI. See our [Configuration page](/docs/concepts/configuration) for more. | |
After you set sensitive environment variables as blank or `null` values in the `compose.yaml` file, you can securely set their actual value with the Defang CLI. See our [Configuration page](/docs/concepts/configuration) for more. |
Co-authored-by: Lio李歐 <[email protected]>
Co-authored-by: Jordan Stephens <[email protected]> Co-authored-by: Lio李歐 <[email protected]>
Co-authored-by: Lio李歐 <[email protected]>
Fixes #134
Updated the Compose page to show what top-level and service-level properties of Compose specification are supported by Defang