Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address SOSO SHACL Feedback & Cleanup #78

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

ThomasThelen
Copy link
Member

@ThomasThelen ThomasThelen commented Dec 18, 2022

A few updates to Slinky for the 0.3.0 release

Slinky Dockerfile

  • Collapsed the redlands installation steps into a single layer
  • Removed /var/lib/apt/lists/ (don't need it after package installs) cite
  • Runs slinky & pip under the user 'slinky' (removes warnings about running as root)
  • Upgrades pip to lates & removes redundant python install (removes more warnings)

Virtuoso

We had two copies of our custom Virtuoso Dockerfile. I removed the redundant one in the test directory

dump-virtuoso

This script requires you to have the dump_nquads function defined within Virtuoso (which default deployments no longer do). I added this function and another bit to copy the data files out of the container.

Web

Addresses a few points in #73. Since the page depends on yasgui and the css, I left them as blocking resources.

Triple Pattern Changes

I ran the SOSO 1.2.3 SHACL file against the triples we're producing in develop with

pyshacl -s ~/science-on-schema.org/validation/shapegraphs/soso_common_v1.2.3.ttl -m -i rdfs -f human data.nq

These are the results. This PR currently fixes the keywords violation and sameAs warning.

  • We currently use schema:keyword for describing keywords - but it should be schema:keywords
  • We're using owl:sameAs where SOSO wants schema:sameAS. Adding both might not be a bad idea (but I went with only using schema)

there was a second violation with schema:version - but I filed an issue for that one.

Google Recommended

We fail a few of the recommended google shapes (we pass the required one though).

SHACL Result
googleReccomended result
googleReccomendedCoverageCheck result

For 0.3.0 these might not be worth addressing and could go in a 0.3.1.

@ThomasThelen ThomasThelen changed the title Develop Address SOSO SHACL Feedback & Cleanup Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant